3 ms·

"...Bun on Windows passes 98% of our own test suite for Bun on macOS and Linux." Does this mean the release was made with failing tests, or am I misunderstandi

"...Bun on Windows passes 98% of our own test suite for Bun on macOS and Linux." Does this mean the release was made with failing tests, or am I misunderstanding?

vallode 3y ago
Looks like it, it seems the 2% are mostly odd platform specific issues that the authors' did not deem very important (my assumption for the release happening anyway). AFAIK this[1] PR tries to fix them. [1]: https://github.com/oven-sh/bun/pull/9729 https://github.com/oven-sh/bun/pull/9729
basil-rash 3y ago
Skipping particular tests depending on platform is a very common practice, for better or worse.
- CaptainOfCoit 3y ago
  That's not what's happening. Bun has tests that are supposed to work on the platform, but currently doesn't. Skipping tests from a Linux suite that doesn't make sense to run on Windows is very common. Skipping tests that should pass on a platform but doesn't just in order to cut a release isn't as common.
  - basil-rash 3y ago
    Every growing project has things thing the maintainers would like to work but that do not currently. The job of the maintainer is to balance the value of releasing a cut of the software as stands and learning about other unknown issues while continuing to work on the known, or to work on the known and ignore the unknown until finished with the known. Neither way is strictly good or bad.
sharas- 3y ago
[flagged]
- latexr 3y ago
  > Bun is run by a little prince. What does that even mean? Bun is run by a fictional French character capable of interplanetary travel? Or are you calling them a spoiled brat with money? Why does that affect code organisation? Or is it code quality? If you’re going to criticise the project and the people who run it, some clarity of communication and specifics on the issues would be appreciated so others can evaluate your claims. Otherwise it’s just empty insults which do not advance the discussion.
baq 3y ago
At some point it becomes infeasible to 100% the test suite for all configurations. At some point further away it becomes infeasible to 100% the test suite for any configuration.

"...Bun on Windows passes 98% of our own test suite for Bun on macOS and Linux." Does this mean the release was made with failing tests, or am I misunderstanding?

vallode 3y ago

Looks like it, it seems the 2% are mostly odd platform specific issues that the authors' did not deem very important (my assumption for the release happening anyway). AFAIK this[1] PR tries to fix them. [1]: https://github.com/oven-sh/bun/pull/9729 https://github.com/oven-sh/bun/pull/9729

basil-rash 3y ago

Skipping particular tests depending on platform is a very common practice, for better or worse.

CaptainOfCoit 3y ago
That's not what's happening. Bun has tests that are supposed to work on the platform, but currently doesn't. Skipping tests from a Linux suite that doesn't make sense to run on Windows is very common. Skipping tests that should pass on a platform but doesn't just in order to cut a release isn't as common.
- basil-rash 3y ago
  Every growing project has things thing the maintainers would like to work but that do not currently. The job of the maintainer is to balance the value of releasing a cut of the software as stands and learning about other unknown issues while continuing to work on the known, or to work on the known and ignore the unknown until finished with the known. Neither way is strictly good or bad.

sharas- 3y ago

[flagged]

latexr 3y ago
> Bun is run by a little prince. What does that even mean? Bun is run by a fictional French character capable of interplanetary travel? Or are you calling them a spoiled brat with money? Why does that affect code organisation? Or is it code quality? If you’re going to criticise the project and the people who run it, some clarity of communication and specifics on the issues would be appreciated so others can evaluate your claims. Otherwise it’s just empty insults which do not advance the discussion.

baq 3y ago

At some point it becomes infeasible to 100% the test suite for all configurations. At some point further away it becomes infeasible to 100% the test suite for any configuration.