5 ms·
That is unrelated. This is a code signing / notarization issue because we don’t distribute Bun via the Mac App Store and likely the way it was installed was via
by Jarred 3y ago
That is unrelated. This is a code signing / notarization issue because we don’t distribute Bun via the Mac App Store and likely the way it was installed was via npm or something other than .zip file we distribute. Code signing is necessary due to the JIT entitlement in Bun (otherwise Bun would be a whole lot slower)
- notelem 3y agoMac code signing needs the machine id? https://github.com/oven-sh/bun/blob/801e475c72b3573a91e0fb4c3afdd53b437770e1/src/analytics/analytics_thread.zig#L182-L193 https://github.com/oven-sh/bun/blob/801e475c72b3573a91e0fb4c... https://github.com/oven-sh/bun/blob/801e475c72b3573a91e0fb4c3afdd53b437770e1/src/analytics/analytics_thread.zig#L274C8-L323 https://github.com/oven-sh/bun/blob/801e475c72b3573a91e0fb4c... Why then is the unique machine id collected on Linux?
- Jarred 3y agoThis is dead code from before Bun 1.0. This code exists but is not run and probably stripped from the final executable (Zig is great at dead code elimination). We do get the Linux kernel version to detect if syscalls like pidfd_open are supported and enable fast paths.