33 ms·
> And it’s not rocket science that well reasoned patches, with tests, splitting out separate commits, explaining the reason for the change would be better recei
by keybored 3y ago
> And it’s not rocket science that well reasoned patches, with tests, splitting out separate commits, explaining the reason for the change would be better received than a typo laden one-liner, “I needz it”.
I said makes an effort.
You can implement a novel feature (and well) and get it rejected.
- koolba 3y agoI’m saying without writing any code I can already tell, within a reasonable level of confidence, if a patch would be accepted by looking through past contributions. You’re not working in a vacuum.