4 ms·
>>> 2. Poor encapsulation, adding private functions requires recompiling all dependents >> under what circumstances does (2) hold? To add a private member var
by phkahler 3y ago
>>> 2. Poor encapsulation, adding private functions requires recompiling all dependents
>> under what circumstances does (2) hold?
To add a private member variable or function, you need to put it in the class definition in the header file. Then anything that includes the header needs to be recompiled.
- ThouYS 3y agothey don't need to be. dependents will continue functioning, because ABI hasn't changed
- jstimpfle 3y agoNow explain that to my build system. But even if you managed to do that, first compilation is still much slower than it should be, because anlot of headers have to be included (transitively) to allow even declaring these fields and methods.
- hkwerf 3y agoAdmittedly, adding a private member variable changes the object size and thus the ABI and thus requires recompilation of dependencies. Thinking about that, is there any case in which private functions can end up in a vtable? In that case, it'd break ABI too.
- NekkoDroid 3y ago> is there any case in which private functions can end up in a vtable? Yes, but it generally isn't something that is done. https://godbolt.org/z/5oPovKzoT https://godbolt.org/z/5oPovKzoT