2 ms·
While you are saying that it is utterly unrelated, I'll respond with "that not only related, this is a root cause of current situation". We have a single massi
by Lockal 3y ago
While you are saying that it is utterly unrelated, I'll respond with "that not only related, this is a root cause of current situation".
We have a single massively used implementation (also known as reference), which does not even follow xz format specification. It is autohell-based, which allowed m4 injection. In other places it is CMake-based, but uses autohell-based code, inserting hidden dots where they could just use https://cmake.org/cmake/help/latest/module/CheckSymbolExists.html https://cmake.org/cmake/help/latest/module/CheckSymbolExists...
"Poor design" is still there, as a core of library. It is as cool, 64-bit square roots and 128-bit divides in Bcachefs[1]
It is as cool as lbzip2[2] with their:
(((0xffffaa50 >> ((as < 0x20 ? as : (as >> 4)) & 0x1e)) & 0x3) + (as < 0x20 ? 1 : 5))
Spoiler: this lbzip2 code produces corrupted files in some cases, should we care if it is a backdoor? Or as usual, disable optimizations, disable valgrind, disable fuzzers and say that everything is ok?
[1] https://www.phoronix.com/news/Linux-6.9-Bcachefs-Attempt https://www.phoronix.com/news/Linux-6.9-Bcachefs-Attempt
[2] https://github.com/kjn/lbzip2/blob/b6dc48a7b9bfe6b340ed1f6d72133608ad57144b/src/encode.c#L1123 https://github.com/kjn/lbzip2/blob/b6dc48a7b9bfe6b340ed1f6d7...