3 ms·

For the first time, I know our (Apache Kvrocks, an alternative to Redis on Flash) committer Binbin Wang committed nearly 25% of the commits to the newer Redis v

by tison 3y ago

For the first time, I know our (Apache Kvrocks, an alternative to Redis on Flash) committer Binbin Wang committed nearly 25% of the commits to the newer Redis version. You can find his contributor for both at: * https://github.com/apache/kvrocks/graphs/contributors https://github.com/apache/kvrocks/graphs/contributors * https://github.com/redis/redis/graphs/contributors https://github.com/redis/redis/graphs/contributors

tison 3y ago
And here is an interesting conversation when Binbin came to the Kvrocks community: https://github.com/apache/kvrocks/pull/1581#issuecomment-1632391700 https://github.com/apache/kvrocks/pull/1581#issuecomment-163... * Me: @enjoy-binbin Out of curiosity, do you have a fuzzer to test out Kvrocks? Your recent great fixes seem like a combo rather than random findings :D * Binbin: They were actually random findings.I may be sensitive to this, doing code review and found them (also based on my familiarity with redis)
- masklinn 3y ago
  Yeah some folks are built different. I’ve a colleague who once every few weeks opens random files and notices weird patterns, I’ve no idea how his mind works but boy does it work.
- ryanjshaw 3y ago
  Why does the fix work like that - only checking for this one scenario when you decrement by type max? [1] In Solidity, where it's a serious security risk, before the language performed overflow checks itself, library authors would perform the arithmetic operation and then e.g. check if the result is larger than the original value in the case of a positive subtrahend [2]. [1] https://github.com/apache/kvrocks/pull/1581/commits/dc5140dd0c7ffdbb028fad238154622a60853b23 https://github.com/apache/kvrocks/pull/1581/commits/dc5140dd... [2] https://github.com/KingdomStudiosIO/contracts/blob/51873b574236822c31d5825351f2492af303fc2d/contracts/libraries/SignedSafeMath.sol#L67 https://github.com/KingdomStudiosIO/contracts/blob/51873b574...

by tison 3y ago

tison 3y ago

And here is an interesting conversation when Binbin came to the Kvrocks community: https://github.com/apache/kvrocks/pull/1581#issuecomment-1632391700 https://github.com/apache/kvrocks/pull/1581#issuecomment-163... * Me: @enjoy-binbin Out of curiosity, do you have a fuzzer to test out Kvrocks? Your recent great fixes seem like a combo rather than random findings :D * Binbin: They were actually random findings.I may be sensitive to this, doing code review and found them (also based on my familiarity with redis)

masklinn 3y ago
Yeah some folks are built different. I’ve a colleague who once every few weeks opens random files and notices weird patterns, I’ve no idea how his mind works but boy does it work.
ryanjshaw 3y ago
Why does the fix work like that - only checking for this one scenario when you decrement by type max? [1] In Solidity, where it's a serious security risk, before the language performed overflow checks itself, library authors would perform the arithmetic operation and then e.g. check if the result is larger than the original value in the case of a positive subtrahend [2]. [1] https://github.com/apache/kvrocks/pull/1581/commits/dc5140dd0c7ffdbb028fad238154622a60853b23 https://github.com/apache/kvrocks/pull/1581/commits/dc5140dd... [2] https://github.com/KingdomStudiosIO/contracts/blob/51873b574236822c31d5825351f2492af303fc2d/contracts/libraries/SignedSafeMath.sol#L67 https://github.com/KingdomStudiosIO/contracts/blob/51873b574...