4 ms·
> no, I don't need to accept your PR just because you put work in it, you should have checked with me first, before doing it Which is a bit rude IMO, and not r
by timhh 3y ago
> no, I don't need to accept your PR just because you put work in it, you should have checked with me first, before doing it
Which is a bit rude IMO, and not really in the spirit of open source. I never demanded that he accept it. A PR is like "here's some code, let me know if it's ok" not "you should merge this code without question".
Here is what I would have written:
"Hi, thanks for the code but I don't think I want to go in that direction because X Y Z." (he didn't give any clear reasons so you'll have to imagine those).
Anyway he's free to do his thing. I was just explaining why I moved away from that library.
- lukan 3y ago"Which is a bit rude IMO, and not really in the spirit of open source. I never demanded that he accept it. " Other people did before you. But I can see how you perceived that reaction to you as hostile. It was definitely a bit rude. I disagree a bit though, that it is not in the spirit of open source. Open source does not necessarily mean open for collaboration. He does accept PRs, if they fit his vision .. and get defensive, when they don't, because he don't want to spend energy arguing why not. He does not have to. So yes, it would be nicer, if he would be nicer. But he is the way he is and still he managed to build a great open source product.