3 ms·
> I don't expect you to ask me to get familiar with a codebase, test, and implement a feature in 3 hours. In any given day, I might find an issue or missing fe
by JoshTriplett 3y ago
> I don't expect you to ask me to get familiar with a codebase, test, and implement a feature in 3 hours.
In any given day, I might find an issue or missing feature in one of my dependencies, clone that repository, make a change, submit a pull request, and move on with my day a few minutes later. This is absolutely an important skill.
I don't expect someone to be able to become an expert with a codebase in 3 hours, or even become deeply familiar with it. I do expect someone to be able to get familiar enough to make a simple change, and to feel comfortable working in a codebase that's new to them.
- mkl95 3y agoIf that thing is in production I wouldn't just change the code, submit a PR and move on with my day. For interviewing purposes it could work, but in the real world it's a reckless attitude.
- toast0 3y agoWhat's your alternative plan for when a dependency is discovered to be broken? I've done Josh's plan a bunch of times. It's why I prefer my dependencies to be open source. Everything is broken, but if it's open source, it's easy to fix it when it's noticed, push to production to fix it for my users, and send a PR to fix it for the world (eventually, if they take my patch; not everyone does, but I've had many accepted)
- simonw 3y agoNothing reckless about submitting a PR - that's what code review is for, to let people discuss changes with other people to reduce the risk of bad code being committed because the developer misses something that someone else could have spotted.