5 ms·
> Should I have received a talk because of that? Of course not. But, if your commit history for last 6 months is just one or two of those one-line changes a m
by khazhoux 3y ago
> Should I have received a talk because of that?
Of course not.
But, if your commit history for last 6 months is just one or two of those one-line changes a month, that might hint that there’s a problem.
- mdp2021 3y agoThat makes your point clear, but then what you are looking for is not a scalar value (that may be for instance be subject to a proportional judgement) but a fuzzy threshold.
- eviks 3y agoMight that hint that the problem that is there is that the metric is bad?
- khazhoux 3y agoSo if you managed a team, and when you look at commit histories you notice that one person has <1 commit a month and you look at the commits and they're trivial... you would disregard any concerns?
- jen20 3y agoI would wonder how it got to the second month, certainly - getting to the point where this kind of post-hoc analysis can actually be done is a serious failing of management.
- xandrius 3y agoThe answer is still "it depends", I would imagine that issues would arise well before you had to look at their commit history. I believe that if you are a good manager, you would just need to look at what tickets get done during the sprint and that's it. If you complete your tickets and pass QA/UAT in 10 LOC, so be it. There is no need to micromanage.
- Moru 3y agoThis is exactly why KLoC is not a good measurement. If you know about this, you will make sure you match everyone else by embellishing your line count with comments, copy and rename functions or extra deep nesting. The manager will still not know anything without looking at everyones code.
- khazhoux 3y agoA good manager should look at everyone's code. A good manager should recognize that if a developer does nothing but annotate code with comments, and that's not what they're expected to be doing, there's a problem.
- Moru 3y agoOfcourse, but if the manager is using the KLoC to decide who to look at, that won't happen.
- rsynnott 3y agoI mean, seems highly role-dependent. If, in practice, your role is to investigate and fix very difficult problems, that’s precisely the sort of commit history one might expect.