5 ms·

It sounds like the kind of half-baked change a junior dev might come up with, but lord knows how it made it through code review and into a release.

raverbashing 3y ago
That's easy to guess The good kernel engineers are working on iPhone or Vision Pro, not on MacOS
- t-sauer 3y ago
  Don't they all use the same kernel?
  - pjmlp 3y ago
    No, because naturally it is different kind of requirements and space is at a price as well. Technically it is kind of the same, but with different set of configured features. Already a bit oldie, "Mac OS X and iOS Internals: To the Apple's Core" https://www.amazon.com/Mac-OS-iOS-Internals-Apples/dp/1118057651 https://www.amazon.com/Mac-OS-iOS-Internals-Apples/dp/111805...
  - galad87 3y ago
    Mostly, but JIT is not allowed in the App Store apps, so probably this change didn't broke anything over there.
    - unilynx 3y ago
      But it will soon be once the EU DMA changes require support for alternative browser engines. Was this change an attempt to lock down too wide permissions a JIT might set up and perhaps really intended for iOS instead of macOS?
      - grodriguez100 3y ago
        I don't think the EU DMA changes will require that JIT is supported. Supporting alternative browser engines is something that can be done perfectly without JIT.
        renonce 3y ago
        Depends on whether Apple’s own browser engine requires JIT. I think the point is to ensure fair competition.
        grodriguez100 3y ago
        Uhm, yes, you are right.
        dahauns 3y ago
        >Supporting alternative browser engines is something that can be done perfectly without JIT. Unless I missed something and the DMA requirement is along the lines of "having to allow other browser engines as long as they don't bring their own JITting Javascript engine", no, it literally can't.
        philistine 3y ago
        Nope it cannot. If Apple is using JIT, which massively speeds up JS, and is denying it to competitors, then Apple is giving itself an unfair advantage and is breaking the DMA. And you know, you’re one web search away from finding the page where Apple directly mentions access to a JIT for alternative browsers: https://developer.apple.com/support/alternative-browser-engines/ https://developer.apple.com/support/alternative-browser-engi...
baq 3y ago
hypothetical excerpt from the commit message: code review: self-reviewed test plan: this change is so obvious no tests are needed
- steve1977 3y ago
  I wish you were joking…
  - baq 3y ago
    those who don't know: ^_^ those who know: -_-
DontBreakAlex 3y ago
I think someone changed the SIGSEV to a SIGKILL to debug something and forgot to revert it before merging (boo reviewer boo !)
Mindwipe 3y ago
Especially when it was not in the beta version and introduced with the release candidate. I do not have very kind words for Apple's dev teams today. Charitably I am trying to think that screwups happen, but this is bad and it is very hard to see how anyone thought merging it into an rc was okay.

raverbashing 3y ago

That's easy to guess The good kernel engineers are working on iPhone or Vision Pro, not on MacOS

t-sauer 3y ago
Don't they all use the same kernel?
- pjmlp 3y ago
  No, because naturally it is different kind of requirements and space is at a price as well. Technically it is kind of the same, but with different set of configured features. Already a bit oldie, "Mac OS X and iOS Internals: To the Apple's Core" https://www.amazon.com/Mac-OS-iOS-Internals-Apples/dp/1118057651 https://www.amazon.com/Mac-OS-iOS-Internals-Apples/dp/111805...
- galad87 3y ago
  Mostly, but JIT is not allowed in the App Store apps, so probably this change didn't broke anything over there.
  - unilynx 3y ago
    But it will soon be once the EU DMA changes require support for alternative browser engines. Was this change an attempt to lock down too wide permissions a JIT might set up and perhaps really intended for iOS instead of macOS?
    - grodriguez100 3y ago
      I don't think the EU DMA changes will require that JIT is supported. Supporting alternative browser engines is something that can be done perfectly without JIT.
      - renonce 3y ago
        Depends on whether Apple’s own browser engine requires JIT. I think the point is to ensure fair competition.
        grodriguez100 3y ago
        Uhm, yes, you are right.
      - dahauns 3y ago
        >Supporting alternative browser engines is something that can be done perfectly without JIT. Unless I missed something and the DMA requirement is along the lines of "having to allow other browser engines as long as they don't bring their own JITting Javascript engine", no, it literally can't.
      - philistine 3y ago
        Nope it cannot. If Apple is using JIT, which massively speeds up JS, and is denying it to competitors, then Apple is giving itself an unfair advantage and is breaking the DMA. And you know, you’re one web search away from finding the page where Apple directly mentions access to a JIT for alternative browsers: https://developer.apple.com/support/alternative-browser-engines/ https://developer.apple.com/support/alternative-browser-engi...

baq 3y ago

hypothetical excerpt from the commit message: code review: self-reviewed test plan: this change is so obvious no tests are needed

steve1977 3y ago
I wish you were joking…
- baq 3y ago
  those who don't know: ^_^ those who know: -_-

DontBreakAlex 3y ago

I think someone changed the SIGSEV to a SIGKILL to debug something and forgot to revert it before merging (boo reviewer boo !)

Mindwipe 3y ago

Especially when it was not in the beta version and introduced with the release candidate. I do not have very kind words for Apple's dev teams today. Charitably I am trying to think that screwups happen, but this is bad and it is very hard to see how anyone thought merging it into an rc was okay.