3 ms·

> Really? Just a git command, a button press on GitHub? So why don't they just do it? Why don't they apply the patches when people send the code in then? Becau

by LtWorf 3y ago

> Really? Just a git command, a button press on GitHub? So why don't they just do it? Why don't they apply the patches when people send the code in then? Because the patch was bad. > Something like a month later the guy just rewrote the patch without even engaging with me. Do you think he'd have done that if the patch was good? Was his version completely identical to yours? > Yeah, that made me feel like shit At least it didn't introduce a new bug to every user… I'm sure collective feelings of the userbase were less harmed in this case. > Sorry but maintainers don't have the moral superiority to demand free labor But you have the moral superiority to demand free labour from maintainers, to review, improve, test your patch? Look at this pull request for example: https://github.com/ltworf/localslackirc/pull/387 https://github.com/ltworf/localslackirc/pull/387 How could a thing like that be merged? When asked to split it, he just proceeded to open tens of pull requests that were all based on the previous one, in a chain. And every commit contains thousands of lines of unrelated changes with what the description is. Then he got upset.

matheusmoreira 3y ago
> Because the patch was bad. > Do you think he'd have done that if the patch was good? Who knows? You posted an example where you explained your rationale for not merging. You told the guy exactly what was wrong, he just refused to listen. I didn't get the same courtesy. Maybe he didn't want my name to show up in the commit log. Maybe he just hated my guts. Could be anything. I don't know why the other patch wasn't merged either. Maybe they discussed it on IRC or something and decided against it. Maybe they forgot about me. Who knows. > But you have the moral superiority to demand free labour from maintainers, to review, improve, test your patch? You're the maintainer. If there's a problem or deficiency, people generally just create issues in the tracker and leave it at that. You asked for the code. You actually got the code. Now we ask you to do your part which is reviewing the code on its merits and letting us know what you think of it. If it's accceptable, then merge it. If not, then let us know why so we can make it acceptable to you. That's exactly what you did in your example PR so I'm not even sure why we're disagreeing here. > How could a thing like that be merged? I wouldn't have merged that either. Nothing wrong with your conduct. He did not address the issues blocking the merger. When maintainers give me feedback like that, I take it seriously and address the issues raised. I try very hard not to submit shoddy work to begin with.

by LtWorf 3y ago

matheusmoreira 3y ago

> Because the patch was bad. > Do you think he'd have done that if the patch was good? Who knows? You posted an example where you explained your rationale for not merging. You told the guy exactly what was wrong, he just refused to listen. I didn't get the same courtesy. Maybe he didn't want my name to show up in the commit log. Maybe he just hated my guts. Could be anything. I don't know why the other patch wasn't merged either. Maybe they discussed it on IRC or something and decided against it. Maybe they forgot about me. Who knows. > But you have the moral superiority to demand free labour from maintainers, to review, improve, test your patch? You're the maintainer. If there's a problem or deficiency, people generally just create issues in the tracker and leave it at that. You asked for the code. You actually got the code. Now we ask you to do your part which is reviewing the code on its merits and letting us know what you think of it. If it's accceptable, then merge it. If not, then let us know why so we can make it acceptable to you. That's exactly what you did in your example PR so I'm not even sure why we're disagreeing here. > How could a thing like that be merged? I wouldn't have merged that either. Nothing wrong with your conduct. He did not address the issues blocking the merger. When maintainers give me feedback like that, I take it seriously and address the issues raised. I try very hard not to submit shoddy work to begin with.