4 ms·

> One of the top things that I want in a job is coworkers who care obsessively. While I agree with the premise, the "downstream" really matters though. There'

> One of the top things that I want in a job is coworkers who care obsessively. While I agree with the premise, the "downstream" really matters though. There's a lot of different ways to care obsessively and many are quite toxic if you've ever worked with them. One example comes to mind is I've been there were PR comments are way overbearing. There's definitely good points/notes, but nitpicking, snide comments, holier-than-art attitude easily comes along with the boat. "With love" is such a blase statement, but it really has to be the starting point. That caring combined with respect has to be present to be a healthy, long term working environment. Like with many things, there's a balance.

jaggederest 3y ago
I'm going to plug my PR log level policy here: I add a tag to my PRs asking for "error level" or "debug level" or whatever in between. Then the reviewer can tune their feedback. I started doing this when I was working with a diverse group of folks with different backgrounds. I'd like it to be a standard thing. I find that I want different kinds of feedback through the process of developing a PR, and whether it's over a day or a month matters a lot too. That way, I can safely be obsessive about things when giving PR feedback, in the knowledge they're asking for "debug level" feedback, or give it just-the-facts review if they're just trying to get something merged that has been reviewed to hell and back.