5 ms·
Are you trying to tell me you actually don't review your staged changes and/or commits before you push them? Also how do you resolve conflicts? Or is this jus
by nextlevelwizard 3y ago
Are you trying to tell me you actually don't review your staged changes and/or commits before you push them?
Also how do you resolve conflicts?
Or is this just your solo project with zero users so you dont have to worry about other people's commits or your own commit's quality?
- PurpleRamen 3y ago> Are you trying to tell me you actually don't review your staged changes and/or commits before you push them? The final review happens in the merge request-view on the forge. There is little reason for local reviewing. Especially when multiple people work on a branch. > Also how do you resolve conflicts? Editor.
- nextlevelwizard 3y agoSo you just push shit in and make a review request and only then check if you actually had the correct things in commit(s) and have a descriptive commit message? Yikes
- PurpleRamen 3y agoI get the impression that many people here seems to be very challenged to know what they actually do. Do you just randomly work on things, barf out different issues into the same branch at the same time?
- user3939382 3y agoAgree. We for example do one branch per bug or new feature. You open a draft PR on GH, review it, then when you think it’s ready open a review and someone else can take a look at the whole branch. The commits serve an auxiliary role in that workflow. I think some people assume everyone uses their exact workflow.