4 ms·
As someone who has received PRs, simply reading the PR is a demand. Hell, getting a notification about the PR is a demand. Reading the message is a demand. R
by Ferret7446 3y ago
As someone who has received PRs, simply reading the PR is a demand. Hell, getting a notification about the PR is a demand.
Reading the message is a demand. Reading the code is a demand. Thinking about whether the approach is satisfactory is a demand. Thinking of a response is a demand.
If you want to maximize your chances, you had better put as much effort into making things as easy for the maintainer as possible, such as including alternate approaches you considered and why they were not chosen, written as succinctly yet clearly as possible. Your code should completely match the existing style and formatting of the code; your own style preferences are irrelevant. Of course, you need to be as polite as possible without being condescending. And even then, you are owed nothing.
That is the approach I take when writing my PRs, and my success rate is rather high (but I still get rejected or ignored).