4 ms·

ComflowySpace: An open-source version of better ComfyUI

8 points by Lwrless 3y ago

Kelteseth 3y ago
Does not work with AMD cards. I get an CUDA error after the installation...
d-z-m 3y ago
Kind of weird phrasing in the title, seems to imply that ComfyUI isn't open-source.
- weebull 3y ago
  Honestly, I look at the readme and I think it's just a minimal effort layer on top of ComfyUI. It's main point seems to be "easier installation" but it's not ComfyUI that's difficult to install. It's the GPU libraries. CPU based ComfyUI is a `git clone` and a `pip install -r requirements`. Shame it's so slow on the CPU, but that's diffusion models for you.
elpocko 3y ago
Weird license. It looks like it's based on ComfyUI, so GPL 3.0 would be the (only?) correct license for this. But the same is also true for custom nodes, and many of them don't give a shit about GPL.
- Zetobal 3y ago
  why would custom nodes need to comply with gpl?
  - elpocko 3y ago
    You can't use a custom node on its own, therefore it is based on ComfyUI, and according to the GPL this means the custom node has to be GPL-licensed. https://www.gnu.org/licenses/gpl-faq.en.html#GPLPlugins https://www.gnu.org/licenses/gpl-faq.en.html#GPLPlugins > If the main program dynamically links plug-ins, and they make function calls to each other and share data structures, we believe they form a single combined program, which must be treated as an extension of both the main program and the plug-ins. IANAL
vergessenmir 3y ago
The non standard licensing puts me off in contributing or using this. It is frustrating how the phrase opensource has been diluted in the AI/ML community. ComfyUI has a GPL license [1] while this project uses this [2]. I honestly don't know where I stand since this is a legal document using non-standard phrasing to describe how the rights around the source code. This is a project that uses a custom license with less rights provided than the ComfyUI project it self-describes as improving. Am not sure the title is reflective of the project. [1] - https://github.com/comfyanonymous/ComfyUI/blob/master/LICENSE https://github.com/comfyanonymous/ComfyUI/blob/master/LICENS... [2] - https://github.com/6174/comflowyspace/blob/main/LICENSE https://github.com/6174/comflowyspace/blob/main/LICENSE
vergessenmir 3y ago
This project is leaving a bit of a sour taste in my mouth, the more I read through it. It may just be because it is early days and I hope the criticisms/questions are taken constructively. Here are question to the OP: - How are multiple environments managed, is my hard disk going to fill from multiple overlapping virtualenvs - How are resources managed for parallel runs, or is this offloaded to the cloud? - It lists Mac OS and Windows as supported platforms, are there plans for there to be a Linux version? (It is a bit surprising the Linux is omitted)
yjftsjthsd-h 3y ago
To more explicitly echo others: This is not Open Source. It is Source Available[0] with usage restrictions. But the license[1] not only restricts commercial use, it fails to even allow modification or redistribution. [0] https://en.wikipedia.org/wiki/Source-available_software https://en.wikipedia.org/wiki/Source-available_software [1] https://github.com/6174/comflowyspace/blob/main/LICENSE https://github.com/6174/comflowyspace/blob/main/LICENSE

8 points by Lwrless 3y ago

Kelteseth 3y ago

Does not work with AMD cards. I get an CUDA error after the installation...

d-z-m 3y ago

Kind of weird phrasing in the title, seems to imply that ComfyUI isn't open-source.

weebull 3y ago
Honestly, I look at the readme and I think it's just a minimal effort layer on top of ComfyUI. It's main point seems to be "easier installation" but it's not ComfyUI that's difficult to install. It's the GPU libraries. CPU based ComfyUI is a `git clone` and a `pip install -r requirements`. Shame it's so slow on the CPU, but that's diffusion models for you.

elpocko 3y ago

Weird license. It looks like it's based on ComfyUI, so GPL 3.0 would be the (only?) correct license for this. But the same is also true for custom nodes, and many of them don't give a shit about GPL.

Zetobal 3y ago
why would custom nodes need to comply with gpl?
- elpocko 3y ago
  You can't use a custom node on its own, therefore it is based on ComfyUI, and according to the GPL this means the custom node has to be GPL-licensed. https://www.gnu.org/licenses/gpl-faq.en.html#GPLPlugins https://www.gnu.org/licenses/gpl-faq.en.html#GPLPlugins > If the main program dynamically links plug-ins, and they make function calls to each other and share data structures, we believe they form a single combined program, which must be treated as an extension of both the main program and the plug-ins. IANAL

vergessenmir 3y ago

The non standard licensing puts me off in contributing or using this. It is frustrating how the phrase opensource has been diluted in the AI/ML community. ComfyUI has a GPL license [1] while this project uses this [2]. I honestly don't know where I stand since this is a legal document using non-standard phrasing to describe how the rights around the source code. This is a project that uses a custom license with less rights provided than the ComfyUI project it self-describes as improving. Am not sure the title is reflective of the project. [1] - https://github.com/comfyanonymous/ComfyUI/blob/master/LICENSE https://github.com/comfyanonymous/ComfyUI/blob/master/LICENS... [2] - https://github.com/6174/comflowyspace/blob/main/LICENSE https://github.com/6174/comflowyspace/blob/main/LICENSE

vergessenmir 3y ago

This project is leaving a bit of a sour taste in my mouth, the more I read through it. It may just be because it is early days and I hope the criticisms/questions are taken constructively. Here are question to the OP: - How are multiple environments managed, is my hard disk going to fill from multiple overlapping virtualenvs - How are resources managed for parallel runs, or is this offloaded to the cloud? - It lists Mac OS and Windows as supported platforms, are there plans for there to be a Linux version? (It is a bit surprising the Linux is omitted)

yjftsjthsd-h 3y ago

To more explicitly echo others: This is not Open Source. It is Source Available[0] with usage restrictions. But the license[1] not only restricts commercial use, it fails to even allow modification or redistribution. [0] https://en.wikipedia.org/wiki/Source-available_software https://en.wikipedia.org/wiki/Source-available_software [1] https://github.com/6174/comflowyspace/blob/main/LICENSE https://github.com/6174/comflowyspace/blob/main/LICENSE