3 ms·

Well here's the thing: Linus is right. Linus does not hesitate to criticize and always think about things before declaring them cool. Oh he makes errors like

by zobzu 15y ago

Well here's the thing: Linus is right. Linus does not hesitate to criticize and always think about things before declaring them cool. Oh he makes errors like everybody. He's usually not always very nice in messages (read LKML and you'll understand). But he's usually right and he's usually not writing random things because "it is trendy". So GitHub is trendy. Linus doesn't care. Linus cares for the good features and pull isn't one of them in his eyes. And then again, I think he's right. Pull in GitHub is crappy. But what's missing from his message is the reason why the GitHub pull is crappy. I'm sure he knows, but he's using half words. Here's the reason: If GitHub enforced proper pull messages PEOPLE WOULDN'T USE IT. Why? Because it's the easyness to fork and pull that make GitHub successful. So you see, pulls have to be DEAD EASY. And that means also "single text field, no enforcement of anything". So yeah. GitHub won't fix it, because it'll be bad for their business.

ash 15y ago
> So yeah. GitHub won't fix it, because it'll be bad for their business. I don't think so. Read tomayko comment in the original thread: GitHub acknowledged the issue with Pull requests. Even if you were right, GitHub could add a way for a project to make its own (enforced) rules.
ryanbrunner 15y ago
I really don't understand why GitHub should fix it, though. It's not like it's impossible to put on a README or something else in a prominent place that pull requests need to follow certain standards. With Linus' current work flow (pull requests via e-mail), it's still perfectly possible to have a horribly structured pull request, and so they've added on rules beyond what the technology can do for how pull requests ought to be formatted. I'm failing to see why the same rules can't be applied to GitHub. Linus invented Git, and it's perfectly possible to have single character commit messages in Git. I'm not quite sure why it's a failing of GitHub that it takes a similarly loose approach to how it deals with pull requests.

by zobzu 15y ago

ash 15y ago

> So yeah. GitHub won't fix it, because it'll be bad for their business. I don't think so. Read tomayko comment in the original thread: GitHub acknowledged the issue with Pull requests. Even if you were right, GitHub could add a way for a project to make its own (enforced) rules.

ryanbrunner 15y ago

I really don't understand why GitHub should fix it, though. It's not like it's impossible to put on a README or something else in a prominent place that pull requests need to follow certain standards. With Linus' current work flow (pull requests via e-mail), it's still perfectly possible to have a horribly structured pull request, and so they've added on rules beyond what the technology can do for how pull requests ought to be formatted. I'm failing to see why the same rules can't be applied to GitHub. Linus invented Git, and it's perfectly possible to have single character commit messages in Git. I'm not quite sure why it's a failing of GitHub that it takes a similarly loose approach to how it deals with pull requests.