5 ms·

antirez via twitter: "Linus, I'm with you. Preserve your bastion of code quality as it's something rare and rapidly fading away." https://twitter.com/#!/antire

antirez via twitter: "Linus, I'm with you. Preserve your bastion of code quality as it's something rare and rapidly fading away." https://twitter.com/#!/antirez/status/201065752395124737 https://twitter.com/#!/antirez/status/201065752395124737

nwmcsween 14y ago
Linux and code quality? I think you may be confused.
- deleted 14y ago
  [deleted]
- chj 14y ago
  Please name one project out performing Linux kernel in terms of your definition of code quality. I'd like to have a surprise.
  - ciupicri 14y ago
    I can't speak for himself, but BSDs, especially NetBSD and OpenBSD are known for their code quality. Quoting from "What is NetBSD?"[1]: "The basic features of NetBSD are: Code quality and correctness ...". [1] http://www.netbsd.org/docs/guide/en/chap-intro.html http://www.netbsd.org/docs/guide/en/chap-intro.html [2] http://corte.si/posts/code/reading-code.html http://corte.si/posts/code/reading-code.html
    - sliverstorm 14y ago
      While you are only doing as chj asks, I would point out that NetBSD and OpenBSD have the advantage of being exceedingly compact, simple, have fewer features, fewer contributors, and generally travel at a slower development pace.
  - nwmcsween 14y ago
    Define code quality: braindead GNU extensions such as nested functions - Linux uses that, How about the separation of DM and MD due to ego's, how every driver without a lib (such as libata) warranting a few exceptions has to rewrite boilerplate for basic things - frame buffer drivers are a good example. How about the syscall bugs - look into glibc if you feel like gouging your eyes out or jemalloc for more tame code. Linux itself is more an ecosystem of code and not a single project some parts are good while others are very very bad.
    - adobriyan 14y ago
      C nested functions were explicitly banned from Linux. What are the others?
    - oijaf888 14y ago
      You know jemalloc was originally written for FreeBSD?
drivebyacct2 14y ago
Because being strong minded about git commit message styles is the same thing as "code quality"?
- inerte 14y ago
  It's part of. A good commit message helps to understand what the changed code does or stopped doing.
- scorpion032 14y ago
  because both are the consequence of a same inner quality. Caring.
  - drivebyacct2 14y ago
    I know what you mean, but I don't think the logic follows properly. I think that someone who cares is likely to write better code than if they didn't, but I can assure from my limited experience working with others, caring and passion doesn't make someone a good programmer.
ryanbrunner 14y ago
I accept and agree with the statement "detailed commit messages and pull requests with context are objectively more useful", but I don't see how GitHub fails in that regard any more than Git does. You can have horrible commit messages and pull requests using e-mail pull requests. You can have the same with GitHub. Ultimately, the decisions of what sort of quality you demand on pull requests ought to be up to the maintainer, and GitHub is doing the right thing by not enforcing a standard that doesn't work for the majority of people.

nwmcsween 14y ago

Linux and code quality? I think you may be confused.

deleted 14y ago
[deleted]
chj 14y ago
Please name one project out performing Linux kernel in terms of your definition of code quality. I'd like to have a surprise.
- ciupicri 14y ago
  I can't speak for himself, but BSDs, especially NetBSD and OpenBSD are known for their code quality. Quoting from "What is NetBSD?"[1]: "The basic features of NetBSD are: Code quality and correctness ...". [1] http://www.netbsd.org/docs/guide/en/chap-intro.html http://www.netbsd.org/docs/guide/en/chap-intro.html [2] http://corte.si/posts/code/reading-code.html http://corte.si/posts/code/reading-code.html
  - sliverstorm 14y ago
    While you are only doing as chj asks, I would point out that NetBSD and OpenBSD have the advantage of being exceedingly compact, simple, have fewer features, fewer contributors, and generally travel at a slower development pace.
- nwmcsween 14y ago
  Define code quality: braindead GNU extensions such as nested functions - Linux uses that, How about the separation of DM and MD due to ego's, how every driver without a lib (such as libata) warranting a few exceptions has to rewrite boilerplate for basic things - frame buffer drivers are a good example. How about the syscall bugs - look into glibc if you feel like gouging your eyes out or jemalloc for more tame code. Linux itself is more an ecosystem of code and not a single project some parts are good while others are very very bad.
  - adobriyan 14y ago
    C nested functions were explicitly banned from Linux. What are the others?
  - oijaf888 14y ago
    You know jemalloc was originally written for FreeBSD?

drivebyacct2 14y ago

Because being strong minded about git commit message styles is the same thing as "code quality"?

inerte 14y ago
It's part of. A good commit message helps to understand what the changed code does or stopped doing.
scorpion032 14y ago
because both are the consequence of a same inner quality. Caring.
- drivebyacct2 14y ago
  I know what you mean, but I don't think the logic follows properly. I think that someone who cares is likely to write better code than if they didn't, but I can assure from my limited experience working with others, caring and passion doesn't make someone a good programmer.

ryanbrunner 14y ago

I accept and agree with the statement "detailed commit messages and pull requests with context are objectively more useful", but I don't see how GitHub fails in that regard any more than Git does. You can have horrible commit messages and pull requests using e-mail pull requests. You can have the same with GitHub. Ultimately, the decisions of what sort of quality you demand on pull requests ought to be up to the maintainer, and GitHub is doing the right thing by not enforcing a standard that doesn't work for the majority of people.