2 ms·

IMO there is absolutely no reason to enable warnings in CI without -Werror. Nobody reads the logs of a successful build. If some warnings are flaky then disabl

IMO there is absolutely no reason to enable warnings in CI without -Werror. Nobody reads the logs of a successful build. If some warnings are flaky then disable them specifically. In my experience most warnings in -Wall are OK and you can suppress the rare false positives in code. Don't suppress without a comment. edit: Having said that there are entirely valid reasons to not have -Werror outside of CI. It should be absolutely disabled by default if you distribute source.

mst 3y ago
This is the sort of situation where I'll consider progressive testing initially - i.e. write out the existing warnings to a file that you commit, add a test that fails if you get any that aren't in the file. As you fix the inherited ones you can regenerate the file, hopefully smaller each time. "If I don't have time to fix all of this -now-, I can at least make sure it can't get any -worse- in the mean time" is a very useful approach when automating the 'make sure' is something quick enough that you can find time for that.