5 ms·
Can someone familiar with the Spring Boot codebase confirm if these comments are useful or not? At a glance - and I'm not a java developer - a handful of the c
by splatzone 3y ago
Can someone familiar with the Spring Boot codebase confirm if these comments are useful or not?
At a glance - and I'm not a java developer - a handful of the comments seem to add some specific context that's not obvious from the code alone:
https://github.com/spring-projects/spring-boot/pull/39754/commits/d69317431c623f9b9be07771dba8e1d153b1e991#diff-06d556cdacae547b52a06e42d38030533e1cca0fc0b28c529f993be2d737ddaeR144 https://github.com/spring-projects/spring-boot/pull/39754/co...
- ptx 3y agoI'm not familiar with this codebase, but to me it doesn't seem to be adding any context – it's simply describing what the implementation does. In particular, the comment about unnecessaryExclusions is just adding noise since it's an internal implementation detail that doesn't matter to the caller.