4 ms·
When I do code review I always review the tests first. If they look through and reasonable then I can be a lot less careful reviewing the rest.
by zeroonetwothree 3y ago
When I do code review I always review the tests first. If they look through and reasonable then I can be a lot less careful reviewing the rest.
- postalrat 3y agoTests never cover everything so exactly what are you looking for?
- Muromec 3y agoFor example, just check the list of units, see that there is one for a happy flow, but none for error flow. Check that a number of tests correlates well with apparent cyclomatic complexity of the code. Check that tests are actually defining and testing relevant behavior and not just "I called method A, dus the method B was called".