3 ms·
No, it's a solution for reviews being an asynchronous process. Even if I get a review within an hour or two, I should be able to continue further work in that t
by Denvercoder9 3y ago
No, it's a solution for reviews being an asynchronous process. Even if I get a review within an hour or two, I should be able to continue further work in that time.
- from-nibly 3y agoIsn't it often better to get a single thing all the way through? I know it feels like you are still working on the same feature, but if you want feedback you shouldn't move onto something else while waiting for it. That completely scrambles your flow. Craming your day with as much "work" as possible isn't faster.
- Denvercoder9 3y agoI don't necessarily create the first PR because I want feedback. The design could've been discussed beforehand, and the PR is just to get a second set of eyes on the details, run the CI checks and to fulfill the review requirements. Nothing that comes out of that would have implications for the follow-on PRs, so why shouldn't I continue working on them?
- from-nibly 3y ago> is just to get a second set of eyes on the details, run the CI checks and to fulfill the review requirements AKA feedback
- mpweiher 3y agoHow is "being an asynchronous process" different from "taking too long", in your opinion? If reviews are instantaneous, how does that inhibit you from continuing to work?