4 ms·
Looks like a partial attempt at reimplementing Google's Piper/Critique workflow. Which works well, but not on GitHub because GitHub is not like Critique or even
by barrkel 3y ago
Looks like a partial attempt at reimplementing Google's Piper/Critique workflow. Which works well, but not on GitHub because GitHub is not like Critique or even Gerrit.
Stacked commits need frequent rewriting of the stack. You push the first commit or two for review then you continue onwards. But you need to address comments on the earlier commits so you continually need to rebase things. This is tedious in git without extra tooling.
The review tooling needs updating to match. Ideally you have 2 dimensional navigation of the stack: up and down the stack, and left and right across revisions.
As a reviewer you want to be able to see the delta between revisions of the same (rewritten, force-pushed) commit to see that comments have been addressed. This needs a UI more like Gerrit and less like GitHub. It also requires some cooperation like Gerrit change IDs so rewritten commits have persistent identity beyond their content hash.