4 ms·
We should probably be doing periodic full codebase reviews anyway, regardless of how PRs are being made. It's only our tools that encourage us to purely look at
by raziel2p 3y ago
We should probably be doing periodic full codebase reviews anyway, regardless of how PRs are being made. It's only our tools that encourage us to purely look at the diff of a PR rather than check out the branch and think more big picture. You could also encourage/force people to write design documents or such before starting work on the actual PRs.
Though, a PR that introduces dead code (function that isn't called anywhere) wouldn't get approved by me :)
- from-nibly 3y agoThat never happens. There are like 100 things that need to happen that never happen that should happen before doing a whole code base review. Reviews either happen before it's merged or they never happen.