3 ms·
The advice here is essentially just the time old "keep PRs small and incremental so they can be properly reviewed", but its nice to see some of the stats/data
by benrutter 3y ago
The advice here is essentially just the time old "keep PRs small and incremental so they can be properly reviewed", but its nice to see some of the stats/data around the size of pull requests in the wild.
I'd be curious to see what those repositories where, and how differently things look based on, say, number of contributors. I found this really interesting:
> According to Graphite’s data, only 24% of massive 1000+ line PRs receive any review comments.
But would love to know what these PRs actually looked like in detail. I have a bunch of stuff on github where I'm essentially the sole maintainer and user, if anyone analysed those projects, there'd see lots of bad practices, like uncommented PRs, commits to main etc etc.
I don't think anyone would be too concerned about those things in my tiny repo though, but I'd be pretty terrified if I saw that kind of stuff happening on a big project with a huge userbase.
- creshal 3y agoEven in multi-user or organizational repositories, I wonder how many >1k SLOC RPs involve tons generated code or (poorly) vendored external dependencies. Typically it's pointless to try to review that in detail, either it applies cleanly or it doesn't.