4 ms·
On the PR front, a lot of the issues can be fixed before a PR is ever submitted: make it clear in the PR process that there should be an issue open before a PR.
by eskibars 3y ago
On the PR front, a lot of the issues can be fixed before a PR is ever submitted: make it clear in the PR process that there should be an issue open before a PR. That gives you an opportunity to discuss with the community before coffee gets written and guide a committer on what the expectations are (and are not).
Some users will fork your code to implement something they see as necessary, so if you're going to reject an issue, the first thing you need to do is understand why the user is requesting it, and what their options are without an implementation
- LorenDB 3y agoCertainly, and I'm not advocating for maintainers to reject requests willy-nilly. It's just that sometimes there are feature requests that make zero sense for you to implement, and you will have to tell the user "sorry, but we're not gonna do that".