4 ms·

It was a breaking change, lots of people had to change their broken code, including me

• donatj 3y ago
  You had to change your code because it was literally broken to begin with. It's not a "breaking change" if a library continues to do exactly what it's advertised as doing in a completely compatible way and already broken code downstream at no fault of the authors suddenly doesn't like it. Say a JPEG library added an additional and completely harmless metadata field - and then some JPEG parser explodes because it had hardcoded metadata fields. That's not a breaking change on the JPEG libraries part. That's just a bug on the parsers part.
  • mgraczyk 3y ago
    My code wasn't broken, I had a tsconfig file that was formatted by prettier and prettier removed trailing commas. Then I updated prettier without reformatting and my tests failed because prettier rejected the now-incorrectly formatted tsconfig file. Also your analogy is wrong and not what is happening here. Suppose that a JPEG encoder encoded files as png when the flag is `--filetype=unknown`. Then in a patch release the behavior changes so that "unknown" means jpeg. That's closer to what happened here.
• silverwind 3y ago
  So, don't upgrade it until you fixed your code?
  • mgraczyk 3y ago
    Normally patch updates do not require you to fix your code but often include desirable security fixes. That is the purpose of semantic versioning.