3 ms·
I can't remember the last time PR comments addressed minor formatting issues at all, in any language. If something is hard to grok it usually has to do with log
by treve 3y ago
I can't remember the last time PR comments addressed minor formatting issues at all, in any language. If something is hard to grok it usually has to do with logic, not if there's a space between `if` and `(`.
- bluSCALE4 3y agoYou're right, I more meant that if you don't format, your code sometimes becomes difficult to read and you become disincentivized to fix anything because git blame will point at you. I run into this all the time when people tell me, don't format the code because we won't know who did what. I get this even from senior devs as if using git blame and history is rocket science. If everyone stops bickering and just formats, all this noise goes away.
- 8n4vidtmkvmk 3y agoIf that's really an issue just reformat the whole code base once and be done with it.
- rashkov 3y agoYep, plus you can always do a git blame of the commit just before this happens. For example git blame a1b2c4 -- foo.js Where a1b2c4 is the commit hash. Could even tag the commit to make it more convenient: git tag beforeRefmt a1b2c4 git blame beforeRefmt —- foo.js and push the tag up for everyone to have access to it git push —-tags