3 ms·

Hey, the Mojo parser author here. the test folder is just for the unit tests. All the benchmarking code is located in the /benchmark folder. It would be great

Hey, the Mojo parser author here. the test folder is just for the unit tests. All the benchmarking code is located in the /benchmark folder. It would be great if you can give it another go on your machine. https://github.com/MoSafi2/MojoFastTrim/tree/restructed/benchmark https://github.com/MoSafi2/MojoFastTrim/tree/restructed/benc...

fwip 3y ago
Thanks for the pointer, I had only checked the 'main' branch, which doesn't have the benchmarking code present. When running on the commit & code you point to here, here are my new results: $ hyperfine -N --warmup 5 './benchmark/fast_parser data/fastq_test.fastq' './benchmark/needletail_benchmark/target/release/rust_parser data/fastq_test.fastq ' Benchmark 1: ./benchmark/fast_parser data/fastq_test.fastq Time (mean ± σ): 675.0 ms ± 2.4 ms [User: 399.3 ms, System: 269.4 ms] Range (min … max): 670.5 ms … 677.5 ms 10 runs Benchmark 2: ./benchmark/needletail_benchmark/target/release/rust_parser data/fastq_test.fastq Time (mean ± σ): 840.8 ms ± 3.0 ms [User: 578.0 ms, System: 257.0 ms] Range (min … max): 837.0 ms … 847.7 ms 10 runs Summary ./benchmark/fast_parser data/fastq_test.fastq ran 1.25 ± 0.01 times faster than ./benchmark/needletail_benchmark/target/release/rust_parser data/fastq_test.fastq Which indeed shows your parser running about 25% faster than the needletail version.
- melodyogonna 3y ago
  Interesting.
- MohamedMabrouk 3y ago
  That's great to see, thanks a ton. care to share your system information? I am trying to understand where the difference is coming from and that would really helpful.
  - fwip 3y ago
    Sure, it's the 14-inch 2021 Macbook Pro (Apple M1 Pro chip), 16GB. Connected to power, other programs running, but nothing actively working. Timings were pretty stable when running a few times.
    - MohamedMabrouk 3y ago
      Thanks a lot!

fwip 3y ago

Thanks for the pointer, I had only checked the 'main' branch, which doesn't have the benchmarking code present. When running on the commit & code you point to here, here are my new results: $ hyperfine -N --warmup 5 './benchmark/fast_parser data/fastq_test.fastq' './benchmark/needletail_benchmark/target/release/rust_parser data/fastq_test.fastq ' Benchmark 1: ./benchmark/fast_parser data/fastq_test.fastq Time (mean ± σ): 675.0 ms ± 2.4 ms [User: 399.3 ms, System: 269.4 ms] Range (min … max): 670.5 ms … 677.5 ms 10 runs Benchmark 2: ./benchmark/needletail_benchmark/target/release/rust_parser data/fastq_test.fastq Time (mean ± σ): 840.8 ms ± 3.0 ms [User: 578.0 ms, System: 257.0 ms] Range (min … max): 837.0 ms … 847.7 ms 10 runs Summary ./benchmark/fast_parser data/fastq_test.fastq ran 1.25 ± 0.01 times faster than ./benchmark/needletail_benchmark/target/release/rust_parser data/fastq_test.fastq Which indeed shows your parser running about 25% faster than the needletail version.

melodyogonna 3y ago
Interesting.
MohamedMabrouk 3y ago
That's great to see, thanks a ton. care to share your system information? I am trying to understand where the difference is coming from and that would really helpful.
- fwip 3y ago
  Sure, it's the 14-inch 2021 Macbook Pro (Apple M1 Pro chip), 16GB. Connected to power, other programs running, but nothing actively working. Timings were pretty stable when running a few times.
  - MohamedMabrouk 3y ago
    Thanks a lot!