3 ms·

https://github.com/awslabs/llrt/blob/e2cc8237f4bd04e161d46b3266b040b81a3a66e6/src/main.rs#L36 https://github.com/awslabs/llrt/blob/e2cc8237f4bd04e161d46b3... T

by rdtsc 3y ago

https://github.com/awslabs/llrt/blob/e2cc8237f4bd04e161d46b3266b040b81a3a66e6/src/main.rs#L36 https://github.com/awslabs/llrt/blob/e2cc8237f4bd04e161d46b3... This wraps QuickJS and there is not a single mention on their front page. At least a hello or shout-out to Fabrice Bellard would have been nice. But I guess it's AWS and they do this with other projects, so not too surprising.

ignoramous 3y ago
> At least a hello or shout-out to Fabrice Bellard would have been nice. Mentioned in the third-party file: https://github.com/awslabs/llrt/blob/630ec79/THIRD_PARTY_LICENSES#L31-L34 https://github.com/awslabs/llrt/blob/630ec79/THIRD_PARTY_LIC... / https://archive.is/0NUAa https://archive.is/0NUAa > AWS and they do this with other projects Remember similar concerns raised viz Firecracker (which is a hard fork of Google crosvm: https://news.ycombinator.com/item?id=22360232 https://news.ycombinator.com/item?id=22360232), but don't recall it being a pattern.
- wswope 3y ago
  > AWS and they do this with other projects Probably a nod to the ElasticSearch licensing debacle.
gfodor 3y ago
Gross.
drschwabe 3y ago
Amazon's repo here is open source at least so perhaps this could be remedied with an edit to their README and a PR - go for it ! Agree with you there should be credit where credit is due - I have been using QuickJS for some time and its awesome. For the cost of about 1MB you can get entire modern JS in your C/C++ binary.
darknavi 3y ago
We use QuickJS in Minecraft for our scripting engine. It's nice that he has got back into it these days and been adding ES2023 support. I also had to double check but we do indeed list it on our website, albeit in a sea of others. https://www.minecraft.net/en-us/attribution https://www.minecraft.net/en-us/attribution
maxloh 3y ago
They just added the reference to QuickJS [0]. > LLRT is built in Rust, utilizing QuickJS as JavaScript engine, ensuring efficient memory usage and swift startup. [0]: https://github.com/awslabs/llrt/commit/054aefc4d8486f738ed3a46dae894deaa95efcb5 https://github.com/awslabs/llrt/commit/054aefc4d8486f738ed3a...
syrusakbary 3y ago
It seems they just added the mention to QuickJS, I assume, based on your feedback: https://github.com/awslabs/llrt/commit/054aefc4d8486f738ed3a46dae894deaa95efcb5 https://github.com/awslabs/llrt/commit/054aefc4d8486f738ed3a... Props to them on the quick fix!
- rdtsc 3y ago
  Public shaming: it's one of the few avenues that work against the likes of AWS.
intelVISA 3y ago
Not a good look tbh, you could glue this together in an evening yet they're ...proud?
- shermantanktop 3y ago
  I'd definitely spend an evening watching a video of you gluing an equivalent solution together. And if you did finished in one evening, you'd be justified in being very proud.
  - intelVISA 3y ago
    Well, if people would watch it I kinda have to now...
hamoodhabibi 3y ago
My only wish for AWS team is that they measure success based on how complete a product is. There are still 4 year old outstanding critical github issues around Cognito. There are lot of things that are advertised that aren't delivered. In fact our trust in AWS and the team has plummeted that we ultimately ditched serverless and went str8 to VPS The days of zero interest rate series B buying up reserved EC2 instances in the millions are gone. As capital gets expensive we see more reluctance to moving to cloud. AWS claims of "10x faster startup @ half the cost" is confirmation that the Serverless movement is DOA
willsmith72 3y ago
Quick everyone submit an update README pr
cxr 3y ago
And there's not a single mention of Charlie Gordon in your comment about QuickJS. Would have been nice.

by rdtsc 3y ago

ignoramous 3y ago

> At least a hello or shout-out to Fabrice Bellard would have been nice. Mentioned in the third-party file: https://github.com/awslabs/llrt/blob/630ec79/THIRD_PARTY_LICENSES#L31-L34 https://github.com/awslabs/llrt/blob/630ec79/THIRD_PARTY_LIC... / https://archive.is/0NUAa https://archive.is/0NUAa > AWS and they do this with other projects Remember similar concerns raised viz Firecracker (which is a hard fork of Google crosvm: https://news.ycombinator.com/item?id=22360232 https://news.ycombinator.com/item?id=22360232), but don't recall it being a pattern.

wswope 3y ago
> AWS and they do this with other projects Probably a nod to the ElasticSearch licensing debacle.

gfodor 3y ago

Gross.

drschwabe 3y ago

Amazon's repo here is open source at least so perhaps this could be remedied with an edit to their README and a PR - go for it ! Agree with you there should be credit where credit is due - I have been using QuickJS for some time and its awesome. For the cost of about 1MB you can get entire modern JS in your C/C++ binary.

darknavi 3y ago

We use QuickJS in Minecraft for our scripting engine. It's nice that he has got back into it these days and been adding ES2023 support. I also had to double check but we do indeed list it on our website, albeit in a sea of others. https://www.minecraft.net/en-us/attribution https://www.minecraft.net/en-us/attribution

maxloh 3y ago

They just added the reference to QuickJS [0]. > LLRT is built in Rust, utilizing QuickJS as JavaScript engine, ensuring efficient memory usage and swift startup. [0]: https://github.com/awslabs/llrt/commit/054aefc4d8486f738ed3a46dae894deaa95efcb5 https://github.com/awslabs/llrt/commit/054aefc4d8486f738ed3a...

syrusakbary 3y ago

It seems they just added the mention to QuickJS, I assume, based on your feedback: https://github.com/awslabs/llrt/commit/054aefc4d8486f738ed3a46dae894deaa95efcb5 https://github.com/awslabs/llrt/commit/054aefc4d8486f738ed3a... Props to them on the quick fix!

rdtsc 3y ago
Public shaming: it's one of the few avenues that work against the likes of AWS.

intelVISA 3y ago

Not a good look tbh, you could glue this together in an evening yet they're ...proud?

shermantanktop 3y ago
I'd definitely spend an evening watching a video of you gluing an equivalent solution together. And if you did finished in one evening, you'd be justified in being very proud.
- intelVISA 3y ago
  Well, if people would watch it I kinda have to now...

hamoodhabibi 3y ago

My only wish for AWS team is that they measure success based on how complete a product is. There are still 4 year old outstanding critical github issues around Cognito. There are lot of things that are advertised that aren't delivered. In fact our trust in AWS and the team has plummeted that we ultimately ditched serverless and went str8 to VPS The days of zero interest rate series B buying up reserved EC2 instances in the millions are gone. As capital gets expensive we see more reluctance to moving to cloud. AWS claims of "10x faster startup @ half the cost" is confirmation that the Serverless movement is DOA

willsmith72 3y ago

Quick everyone submit an update README pr

cxr 3y ago

And there's not a single mention of Charlie Gordon in your comment about QuickJS. Would have been nice.