4 ms·
There's a lot of "just make it work" code in there. A "customer said software didn't work in China because of a missing cert, now importing cert on startup and
by jeroenhd 3y ago
There's a lot of "just make it work" code in there. A "customer said software didn't work in China because of a missing cert, now importing cert on startup and it works" kind of deal.
For a while it used `sed` to disable Wayland on Linux in a way that only applies to Gnome (specifically on Ubuntu and a few other distros). The code also has a bunch of other exec()s with several commands piped into each other to parse the output.
None of it seems ill-intended, but it's code I would straight reject if I would be tasked to review it.
- GoblinSlayer 3y agoIt's not the first quality Chinese software.