3 ms·
I guess that is still valuable. Maybe someone else will pick it up and write the tests for it. Contribution is contribution is great!
by Derbasti 15y ago
I guess that is still valuable. Maybe someone else will pick it up and write the tests for it. Contribution is contribution is great!
- tkellogg 15y agoI usually reject pull requests with no tests. For one, tests often do a better job describing what the pull request is for than the actual description. Also, it's easier if they think through all the corner cases. It's true, it makes a bigger barrier to entry. But on the other hand, it also gives more value to the contributions. But maybe I should rethink my stance...