4 ms·
Good developers know that writing code is only 1/10th of the work. Then you have to test it, write automated tests, support it, maintain it, etc, etc. I have
by brown 14y ago
Good developers know that writing code is only 1/10th of the work. Then you have to test it, write automated tests, support it, maintain it, etc, etc.
I have contributed to open source before. I often have time/energy to write the original patch, but not enough to write tests and whatnot. Rather than feeling good about my contribution, I typically feel guilty about not supporting the change as much as I should. That feeling of guilt leads to hesitation every time I see an opportunity to contribute.
tl;dr: laziness
- Derbasti 14y agoI guess that is still valuable. Maybe someone else will pick it up and write the tests for it. Contribution is contribution is great!
- tkellogg 14y agoI usually reject pull requests with no tests. For one, tests often do a better job describing what the pull request is for than the actual description. Also, it's easier if they think through all the corner cases. It's true, it makes a bigger barrier to entry. But on the other hand, it also gives more value to the contributions. But maybe I should rethink my stance...