3 ms·
Writing good commit messages is part of your job in the sense that no reviewer should be approving anything without them, knowing that you may or may not be ava
by erik_seaberg 3y ago
Writing good commit messages is part of your job in the sense that no reviewer should be approving anything without them, knowing that you may or may not be available if it breaks next year at 3 AM.
- kaashif 3y agoI put that kind of thing in the pull request, since that's where the review happens. Every commit links back to a pull request, and people actually do refer back to it. Writing good documentation there is part of the job. No-one's going to ALSO write commit messages that no-one will see.
- wnoise 3y agoThe git history will last longer than the platform hosting the PR.
- erik_seaberg 3y agoNot only is “git log” always up, I can also skim it without opening a hundred browser tabs.
- cozzyd 3y agopull requests don't live in the repository (as far as I can tell...) and require you to use whatever online interface creates them. Not sure whey e.g. Github Pull request merges don't include the entire pull request description in the merge commit message.