3 ms·
Honestly, making fixes for review comment separate commits is bad practice. Long term, what you want is for the history of the project to be a long chain of in
by ajross 15y ago
Honestly, making fixes for review comment separate commits is bad practice. Long term, what you want is for the history of the project to be a long chain of individually justified changes that do something "real" with the software. What you don't want is a bunch of churn like "Fix whitespace per buss's comments" or "Use correct naming scheme".
And what you really don't want is for some of those commits to be broken: to the extent practical all commits should be testable so that tools like "git bisect" will work.
So the proper behavior for someone submitting a pull request is to rework the whole thing and submit it again, not patch on top of the original. Check how the kernel works for a great example of this.