3 ms·

I think pull requests are awesome, especially where you're making a 5-20 line change on some really important bit of your site. It's really simple to see what's

I think pull requests are awesome, especially where you're making a 5-20 line change on some really important bit of your site. It's really simple to see what's changed and have colleagues do code-review really quickly. But when you're implementing a major feature, it falls apart. Today, I had to code-review a pull request with 195 separate commits, a 3000-line diff and a combination of css, coffeescript & ruby. Pull requests become pretty useless at this point. Sure, you can do intermediary pull-requests, but at the end you're left with this huge beomoth and no idea where to start. Intermediary diffs could be the answer. Perhaps also the ability to filter the pull request (eg. don't show me the CSS)

briandoll 14y ago
Another great part of using pull requests, is that they allow everyone to see what's going on, mid-stream. They are awesome for major features, especially if you open them early on. We all collaborate via pull requests as various features are being worked on. This way, when someone leaves a comment asking about the overall design (code or visual), suggesting a different approach, it's done while the feature is in development, not when the author thinks the feature is ready to ship. Doing a big code review after a feature has been completely built and is ready to ship seems like a mini-waterfall process.