3 ms·

OBS merges AV1 support for WebRTC

• atonse 3y ago
  I expected there to be a lot more code here... were the codecs themselves merged before? Is it using a library that's doing all the heavy lifting that was merged before? Also is using "hard-coded" methods like is_av1 a best practice in C, as opposed to something like codec == "av1" or member?(codec, "av1") etc. I have to assume it has to do with minimizing dynamic memory allocations... (pardon the rudimentary C questions, I haven't coded in C in 20 years)
  • _lvbh 3y ago
    I think this is specifically adding AV1 to WebRTC. AV1 has already been supported for a while. It’s just an extra if condition and handling
  • Sean-Der 3y ago
    Most of the work happened in the libdatachannel! You can check out my PR here[0] OBS already has everything around AV1, so I just needed to handle packetization :) The `is_av1` is already going away. Bad code on my part <_< [1] [0] https://github.com/paullouisageneau/libdatachannel/commit/a66006add23dcaa0657ec5005150333c3fcc6fa2 https://github.com/paullouisageneau/libdatachannel/commit/a6... [1] https://github.com/obsproject/obs-studio/pull/10159 https://github.com/obsproject/obs-studio/pull/10159