4 ms·

Check OpenBreweryClient.php for comment rot, e.g. references to Blizzard and ‘game’ APIs.

by nrichardson 3y ago

hipadev23 3y ago
[flagged]
- edmundsauto 3y ago
  This line of comments is toxic but so close to being constructive that I have to comment. You had an opportunity to help a php newb get better. Your comment even did the work to present the ways to improve the code. It’s all undercut by the tone, however, which really sounds like you’re just shitting on OP. It would have been easier to just call out ways OP can improve than to shit on their work. Why take the extra effort to be mean?
  - hipadev23 3y ago
    [flagged]
    - edmundsauto 3y ago
      The overall tone is dismissive. If I were new to php and read this, my only takeaway would be “this is awful you are not cut out to program why even bother.” The last line is also mean - you don’t need to diminish the scope for someone’s first project. Was the purpose of your comment to help this person improve? Or to show your superiority? It came across as the latter but was so close to being really awesome if the negativity werent present.
    - pvg 3y ago
      It’s a dismissive put down with a side of chatGPT swipery. You can’t comment on other people’s work like that, especially in a show HN. Criticism has to be constructive rather than tropey. Take a look at https://news.ycombinator.com/newsguidelines.html https://news.ycombinator.com/newsguidelines.html and https://news.ycombinator.com/showhn.html https://news.ycombinator.com/showhn.html
- joeymckenzie 3y ago
  Thank you for the feedback! I'm still fairly new to PHP, coming from the .NET/TypeScript world. Unfortunately, it wasn't ChatGPT generated and I'm well aware there's still a lot to learn. I'm always looking for ways to improve, so if you'd like to create a few issues, I'd be more than happy to address them and get the chance to dig deeper into PHP.
  - edmundsauto 3y ago
    You have a great attitude and if you can take the constructive criticism and ignore the rest, you will have a fast growth curve. Nice work and thanks for being courageous enough to post imperfect code. I’ve used php since 2004 and wouldn’t be this brave.
    - joeymckenzie 3y ago
      Thank you, I really appreciate it! It can definitely be daunting putting something out into the wild for people to see, but I've found the constructive criticism (in most cases) that comes with the territory can only help improve whatever it is I'm working. Gotta take it all in stride.
  - hobs 3y ago
    Not being a php-er, it sounds like a good linter/editor support would probably get you a long way - I like using the Jetbrains stuff and they usually have a useful page like https://www.jetbrains.com/help/phpstorm/php-code-quality-tools.html https://www.jetbrains.com/help/phpstorm/php-code-quality-too... which walks you through the things that people would nitpick you about.
    - joeymckenzie 3y ago
      Absolutely agree, on the todo list. Only using PHPStan/Pint at the moment, though I've looked a bit into the other tools as well and definitely want to get them involved soon to help me as a I go. I've been a loyal JetBrains guy for almost a decade, and I gotta say... PHPStorm is up there with IntelliJ competing for best IDE. I use Rider daily at work, so any chance I get to use familiar tooling in another language feels like it helps level out the learning curve a bit.
joeymckenzie 3y ago
Thanks for pointing that out. Definitely some leftover copy/pasta from another learning library I was writing for PHP. Updated!

Check OpenBreweryClient.php for comment rot, e.g. references to Blizzard and ‘game’ APIs.

hipadev23 3y ago

[flagged]

edmundsauto 3y ago
This line of comments is toxic but so close to being constructive that I have to comment. You had an opportunity to help a php newb get better. Your comment even did the work to present the ways to improve the code. It’s all undercut by the tone, however, which really sounds like you’re just shitting on OP. It would have been easier to just call out ways OP can improve than to shit on their work. Why take the extra effort to be mean?
- hipadev23 3y ago
  [flagged]
  - edmundsauto 3y ago
    The overall tone is dismissive. If I were new to php and read this, my only takeaway would be “this is awful you are not cut out to program why even bother.” The last line is also mean - you don’t need to diminish the scope for someone’s first project. Was the purpose of your comment to help this person improve? Or to show your superiority? It came across as the latter but was so close to being really awesome if the negativity werent present.
  - pvg 3y ago
    It’s a dismissive put down with a side of chatGPT swipery. You can’t comment on other people’s work like that, especially in a show HN. Criticism has to be constructive rather than tropey. Take a look at https://news.ycombinator.com/newsguidelines.html https://news.ycombinator.com/newsguidelines.html and https://news.ycombinator.com/showhn.html https://news.ycombinator.com/showhn.html
joeymckenzie 3y ago
Thank you for the feedback! I'm still fairly new to PHP, coming from the .NET/TypeScript world. Unfortunately, it wasn't ChatGPT generated and I'm well aware there's still a lot to learn. I'm always looking for ways to improve, so if you'd like to create a few issues, I'd be more than happy to address them and get the chance to dig deeper into PHP.
- edmundsauto 3y ago
  You have a great attitude and if you can take the constructive criticism and ignore the rest, you will have a fast growth curve. Nice work and thanks for being courageous enough to post imperfect code. I’ve used php since 2004 and wouldn’t be this brave.
  - joeymckenzie 3y ago
    Thank you, I really appreciate it! It can definitely be daunting putting something out into the wild for people to see, but I've found the constructive criticism (in most cases) that comes with the territory can only help improve whatever it is I'm working. Gotta take it all in stride.
- hobs 3y ago
  Not being a php-er, it sounds like a good linter/editor support would probably get you a long way - I like using the Jetbrains stuff and they usually have a useful page like https://www.jetbrains.com/help/phpstorm/php-code-quality-tools.html https://www.jetbrains.com/help/phpstorm/php-code-quality-too... which walks you through the things that people would nitpick you about.
  - joeymckenzie 3y ago
    Absolutely agree, on the todo list. Only using PHPStan/Pint at the moment, though I've looked a bit into the other tools as well and definitely want to get them involved soon to help me as a I go. I've been a loyal JetBrains guy for almost a decade, and I gotta say... PHPStorm is up there with IntelliJ competing for best IDE. I use Rider daily at work, so any chance I get to use familiar tooling in another language feels like it helps level out the learning curve a bit.

joeymckenzie 3y ago

Thanks for pointing that out. Definitely some leftover copy/pasta from another learning library I was writing for PHP. Updated!