2 ms·
The title is an unnecessary editorial of the PR title. Also, this highlights the importance of naming in software. Because, by any account and interpretation, H
by bmitc 3y ago
The title is an unnecessary editorial of the PR title. Also, this highlights the importance of naming in software. Because, by any account and interpretation, Hong Kong is in China. But that is apparently not what this function is doing, yet it is named "isInChina". It should have been named something else, such as "shouldSetGoProxy", which would resolve any ambiguity.
- sgammon 3y agoIt's the original PR title. Hong Kong is not "physically" "in" "China" in the same sense as a computer which is physically, or legally, in China, and therefore subject to Great Firewall rules.