3 ms·
What if a pr was actual code review and not performative bullshit?
by StreetChief 3y ago
What if a pr was actual code review and not performative bullshit?
- buster 3y agoThat doesn't mean you have to block the merge to main. You can do code reviews on the trunk, you can do it on already merged PRs and you can block on the PR until the code review is done. The latter brings a lot of downsides, which we as developers seem to be taking for granted. It looks like developers can't even imagine not working with Github style pull requests. It depends on your project, but i prefer having a coherent view on all changes on one branch, instead of 20 branches and one outdated trunk.