5 ms·
Critical Gitlab vulnerability exposes 2FA-less users to account takeovers
- czbond 3y agoFor Self - hosted Gitlab instances
- dfc 3y ago...that do not use LDAP.
- sarki_247 3y ago(GitLab Team member here) You can learn more about the disclosure from GitLab, the security releases made and the recommended actions at https://about.gitlab.com/releases/2024/01/11/critical-security-release-gitlab-16-7-2-released/ https://about.gitlab.com/releases/2024/01/11/critical-securi...
- nemoniac 3y agoAm I missing something or does the security release recommend updating to the latest version without saying what that latest version is (at time of writing)? Come to think of it, how can you find what version of Gitlab is being run? (through the web interface on a CE instance)
- upon_drumhead 3y agoIt says it three times in the first three sections. For example > Today we are releasing versions 16.7.2, 16.6.4, 16.5.6 for GitLab Community Edition (CE) and Enterprise Edition (EE).
- adamjb 3y ago>how can you find what version of Gitlab is being run? (through the web interface on a CE instance) It's up the top at gitlab.example.com/help
- maxnoe 3y agoHow does the attacker introduce the controlled email as secondary email of the user they want to take over?
- NoZebra120vClip 3y agoSeveral years ago, I informed GitLab and a few other services that their MFA implementation was faulty. Any user with control of the designated email address could reset the password on an account without knowing that password. GitLab and the others told me that this was not a vulnerability, because that is not part of their threat model after all.
- canadiantim 3y agoIsn’t the point of resetting a password that you don’t know the password?
- huggingmouth 3y agoSure, but then you can't call it mfa.
- RamblingCTO 3y agoOf course you can: password + email access = two factors = multi-factor
- NoZebra120vClip 3y ago> Of course you can: password + email access = two factors = multi-factor No, you're resetting an unknown password, bypassing one of those factors.
- RamblingCTO 3y agoHm, that's true. I'd say it's not good 2fa, but it is 2fa tho. Matter of definitions.
- em-bee 3y ago2fa means BOTH factors are needed. the situation you are discussing here is not password and email but password or email. either one would work. i have seen services that send a token to your email every time you log in or when you log in on a new device or when you haven't logged in in a long time. that would indeed be a form of 2FA. but these services also allow you to reset the password through email, so it's not exactly 2FA all the time like most other 2FA setups.
- declan_roberts 3y ago> GitLab doesn't support SMS-based 2FA – the most commonly hijacked implementation – only supporting app-based 2FA or that issued via a WebAuthn device, which are much more secure. I’m glad the register is calling this out. I hate handing over my personal phone number to a website for my “security”. Yeah right security, and not for your anti-spam and tracking purposes. App-based 2FA is much better, especially passkeys.
- _lvbh 3y agoHere is the commit in which this was fixed: https://gitlab.com/gitlab-org/gitlab/-/commit/abe79e4ec437988cf16534a9dbba81b98a2e7f18 https://gitlab.com/gitlab-org/gitlab/-/commit/abe79e4ec43798...