3 ms·
> PRs should be reviewed before code executes on your infrastructure Very often local tests results can't be trusted specially for projects with architecture l
by YetAnotherNick 3y ago
> PRs should be reviewed before code executes on your infrastructure
Very often local tests results can't be trusted specially for projects with architecture level codes like pytorch. Before merging the test results needs to be checked. And it doesn't require just PR review to be safe, it requires review of all the commits as the contributor is making the changes to fix the testcase. Even if we assume that the maintainer will review each of the commit within a day, it could take weeks or months for the contributor to fix the failing testcase with this and maintainer to be looking at the same PR everyday.