3 ms·
Thanks for the feedback! For the first one the SAST scanner reports to us issues based on lines and issue type, so we generate fixes isolated for that issue. W
by asadeddin 3y ago
Thanks for the feedback!
For the first one the SAST scanner reports to us issues based on lines and issue type, so we generate fixes isolated for that issue. We do not generate fixes for other vulnerabilities in the same file for the same finding in the same because we want to have one fix to one finding. There might be another issue reported on another issue, and we plan on allowing people to group fixes in the same file together.
Not sure if I'm missing something on the shell=True. It's in the vulnerable code, which is why it changed it. You have to scroll to the right in the code viewer.
https://github.com/RhinoSecurityLabs/cloudgoat/blob/8ed1cf0e29e13e2e5887dadcdbcdf88a29d25a19/scenarios/vulnerable_lambda/terraform/lambda_source_code/policy_applier_lambda2_src/click/_termui_impl.py#L491 https://github.com/RhinoSecurityLabs/cloudgoat/blob/8ed1cf0e...
Is there something I'm missing?
- reflexe 3y agoFor the first issue: I understand. Thanks. As for the second, There is no shell=True for me in the demo but it is present in the code you sent. So maybe it is just a bug in the presentation somewhere.
- rplnt 3y agoSame here, must be a bug in the view, for me it's missing the closing parenthesis as well.
- asadeddin 3y agoScrolling to the right should work, but you'll need to do so on each code editor section. We should combine scrolling of these two windows to be in sync. We'll also take a look at what's causing this. It might be a browser issue.