3 ms·
Just because you don’t see tests doesn’t mean that there weren’t any before or now. Really not unmanageable at the size of the code base for me. I do agree t
by alexpadula 3y ago
Just because you don’t see tests doesn’t mean that there weren’t any before or now. Really not unmanageable at the size of the code base for me. I do agree that method is long but I didn’t want to spread that and a few others across many others it was a design choice. I agree it could be improved but to not want to implement it because of that is your choice. The code is commented and continuously gets more comments and it’s very easy to follow if you read procedurally.
- latchkey 3y ago> for me These keywords are the crux of the issue. What you're expecting is that third parties can read your mind. You have the whole codebase floating in your head so you understand where things are at and how it is laid out. If I'm working with others, or expecting people to pick up my project and either use it or contribute to it, I generally try to make it as easily understood as possible. Common sense is to break the file into manageable sections. Again, tons of ways to skin a cat... but this is a huge red flag, for me.
- alexpadula 3y agoInteresting, well understood. I’ll try my best to rethink that logic and get it even shorter. I have no problems with that!! Thank you for taking a look.
- alexpadula 3y agoI really tried to make everything as understandable as I could truly and I will continuously strive to do so. Mind you I only built it in around 60 days so everything will come :)
- latchkey 3y agoPlease don't get me wrong, this is just hopefully constructive feedback from my personal opinion having written A LOT of mission critical golang code. Again, so many ways to skin a cat... if you can convince other people to contribute to your project as it is, then I'm definitely worthy of ignoring. =)
- alexpadula 3y agoI appreciate it latchkey!