4 ms·
I think it depends why the conflict happened. If it happened because say someone else did a refactor then rebasing on that refactor (and that might actually me
by quickthrower2 3y ago
I think it depends why the conflict happened.
If it happened because say someone else did a refactor then rebasing on that refactor (and that might actually mean manually doing a lot of stuff) is easy to inspect. The problem comes through as a commit with something weird unrelated to the change.
It does require line by line code review by the coder, which few might want to do, but I like to do before opening any PR. Because in any case it is so easy to have an editor window open while your cat walks on the keyboard and pastes your password, or whatever :-).
- hmeh 3y agoHonestly, we have so many repositories and such high communication between work cells that merge conflicts are exceedingly rare. If someone did change something out from under me, I could very well see myself doing my work over on top of theirs, and a rebase may help with that, but I would certainly try to merge first. I tend to use rebase solely when I specifically want to rewrite history so as to pretend it was different than it was. Thanks for engaging and discussing!
- quickthrower2 3y agoI agree it is rare. And rarer when you learn to make your PRs smaller!
- deleted 3y ago[deleted]