3 ms·
The subject-first style felt grating at first, but comparing the two I found myself reading more per line than I did in the verb-first approach. Fix skip fix s
by gherkinnn 3y ago
The subject-first style felt grating at first, but comparing the two I found myself reading more per line than I did in the verb-first approach.
Fix skip fix skip fix skip add skip
I knew nothing at the end. The second style had me grasp more, as there were no obvious hooks to skip without knowing what had changed.
But as others have said, commit messages are a cesspool of bikeshedding and ultimately useless, unless every commit is a self-contained chunk of work which it rarely is.
On the side, I enjoyed all of this author's thoughts in the repo. Good find.
- hmeh 3y agoAuthor here. Thank you! I agree that there can be plenty of bike shedding about them, which is why we have an approach that is based on human psychology and can be backed up in that way. We don't often put too much more in the content of a commit message -- the diff, plus the repo it's in (we have many repos) tell you most what what you need to know. If you want more context, every team member has a daily work log that is available to the entire team, so you can see more about what they worked on and why in that work log.
- pseudalopex 3y ago> I agree that there can be plenty of bike shedding about them, which is why we have an approach that is based on human psychology and can be backed up in that way. You optimized for a micro benchmark and presented no data.
- hmeh 3y agoIt was a design decision, and like most design decisions, it was based on first principles and a-priori knowledge. If we had to base all of our design decisions on data and benchmarks, we wouldn’t be able to design anything. I can assure you, that if a better format with better properties came around, we would likely switch to it (assuming we accounted for switching cost and the variation we would be introducing).