3 ms·
Let's not forget people that commit trailing whitespace, or different line-endings. Can we put those on a separate List?
by cerved 3y ago
Let's not forget people that commit trailing whitespace, or different line-endings.
Can we put those on a separate List?
- Vinnl 3y agoTo be fair, we've got computers (CI, pre-commit hooks) that can stop that.
- sgarland 3y agoTo be pragmatic, the number of times I’ve had to fix or outright create CI for other teams because they didn’t bother to add these basics is too damn high. For anything with my team (or personal projects), where I can be guaranteed everyone understands exactly what I’ve set up, I add a pre-commit hook to fix minor linting issues and then add the change to the commit. If black, tf fmt, shfmt, etc. can just fix the problem, then do so, and don’t bother asking me if I’m sure.