6 ms·
If you read nothing else, the commit message adding JIT support is worth your time: https://github.com/python/cpython/pull/113465 https://github.com/python/cpyt
by ath0 3y ago
If you read nothing else, the commit message adding JIT support is worth your time: https://github.com/python/cpython/pull/113465 https://github.com/python/cpython/pull/113465
- shevis 3y agoWow I underestimated how good it would be
- dist-epoch 3y ago[flagged]
- mgaunard 3y ago[flagged]
- vincnetas 3y agoYeah, I'm getting old. I would prefer TLDR formal version and then the fun xmas version for people that feel festive. But hey I'm not paying for this so who am I to complain :)
- dist-epoch 3y ago[flagged]
- simonw 3y agoI'm certain the poetry wasn't GPT generated.
- ajkjk 3y agoWhy do you suspect that? I really doubt it, because it's actually good. Do you think that nobody is able to write good poetry without help from machine? Like... I've written stuff like that in my life. It's not even particularly hard, if you believe you can do it and workshop it for a while.
- RheingoldRiver 3y agoNo way an LLM came up with "Now cache away, cache away, cache away all!" https://chat.openai.com/share/9f701679-43b1-45b7-9f70-9b1c26cbfd57 https://chat.openai.com/share/9f701679-43b1-45b7-9f70-9b1c26...
- Smaug123 3y agoYeah, ChatGPT can't reliably generate poetry which scans. (It can't count syllables in words, so this would be a bit much to expect of it.) I haven't read the entire poem, but the bits I have seen at least have the right syllable counts (although some rather odd stress patterns).
- Uptrenda 3y agoTo the guy who said the pull was horrible: IMO, the most important thing about a pull request is to... actually be productive. I've worked with people in the past who would nit-pick my commit messages wanting me to waste hours of my time trying to use arcane Git commands. Any of which might and probably will clobber my work. If you're doing Git reviews a good use of resources is to look for security problems, performance issues, and general engineering problems with someone's code, etc. A BAD use of Git reviews is to spend the time making stylistic comments 'I would have written it like this, it looks much better', being overly pedantic about code formatting, or forcing your OCD on someone for their Git history. The reason people hate code reviews is somehow they're always done by this latter group of person. If you're forcing people to waste time for silly reasons then you can count that they'll eventually leave your silly company. I know I have. I was once about to work at a company but saw that they literally used a committee of people to review every commit message wherein they would force every engineer to rewrite code for reasons that seemed to make astrology seem like a hard science. Consider not doing that.
- a1o 3y agoA good reason for enforcing some rule on git commit messages though is to have a message that helps when bisecting to find where an issue was introduced in the past. If the commit message is too meanless or too different from whatever is the convention, it makes you spend more time when tracking and solving issues.
- PartiallyTyped 3y agoIf you’ve a test checking the regression you can use that directly to find where the regression occurred without relying on the message, no?
- a1o 3y agoNo, the message should tell the why of the change, if you don't know you risk doing a fix that is simply removing the change and then you are back at the issue that motivate such change in first place. This is even harder if the person put the commit along others that are merged separately or worse, work directly on the main/master branch. I've been there a lot, it's not hard to write a good commit message, if you're in a project and everyone does their part except that one programmer, you will notice a lot every time a bug turns out to be introduced by that one person.
- globular-toast 3y ago400+ commits with a ton of them being "catch up to main"? Wow, I guess even good programmers don't know how to rebase/use git properly.