3 ms·
There is _a lot_ wrong with Marlin. It is a complex codebase, full with ancient artefacts, litterred with preprocessor ifdefs every 2-3 lines of code, dynamic i
by slau 3y ago
There is _a lot_ wrong with Marlin. It is a complex codebase, full with ancient artefacts, litterred with preprocessor ifdefs every 2-3 lines of code, dynamic includes in the middle of CPP files, etc[1]. It's about as unreadable as C++ code gets--well, I guess it's not template metaprogramming.
Klipper by contrast is a breeze to read through[2].
I am very grateful for Marlin, for all of reprap, and everyone who has contributed to it. But saying there is nothing wrong with it is straight up misguided.
[1]: https://github.com/MarlinFirmware/Marlin/blob/bugfix-2.1.x/Marlin/src/lcd/marlinui.cpp https://github.com/MarlinFirmware/Marlin/blob/bugfix-2.1.x/M...
[2]: https://github.com/Klipper3d/klipper/blob/master/src/lcd_hd44780.c https://github.com/Klipper3d/klipper/blob/master/src/lcd_hd4...