5 ms·
Disgusting is a word, but I'm guessing you'd say the same about most unsupported feature code (aka unsafe). You can make code like this reliable in the ways it
by oooyay 3y ago
Disgusting is a word, but I'm guessing you'd say the same about most unsupported feature code (aka unsafe). You can make code like this reliable in the ways it needs to be while still being "unsafe". That's kind of table stakes when you start dabbling in unsupported things.
- tedunangst 3y agoAnd what does this code do to make itself reliable in the event the go authors change the internal structure of a map?
- rad_gruchalski 3y agoNothing. That’s the trade off. What is not clear about “unsafe” in that context?
- tedunangst 3y agoThe part about making it reliable in the ways it needs to be.
- oooyay 3y agoIt's pinned to a Go version and these: https://github.com/dolthub/maphash/blob/main/hasher_test.go https://github.com/dolthub/maphash/blob/main/hasher_test.go
- tedunangst 3y agoThat's annoying, but at least reliable. Thank you.