4 ms·

Lip service is an important skill when dealing with toxic individuals. If it's unimportant to the project, agree and move on. E.g. "your code is badly written,

Lip service is an important skill when dealing with toxic individuals. If it's unimportant to the project, agree and move on. E.g. "your code is badly written, but we've a tight deadline so I'm letting it pass the review". If it was a real issue it wouldn't pass, this is usually just stylistic criticism (unless of course you've ignored good practices like SOLID etc ;) ) and indicative of a new senior who still can't differentiate between functional and problematic code issues.

digitalsushi 3y ago
The wink emoji is leaving me with the sensation I am out in the dark on something everyone else knows.
- morbicer 3y ago
  I am not sure what the wink is, I think SOLID is mostly solid but my advice is be wary of anyone who is a zealot follower of Uncle Bob :)
  - ecshafer 3y ago
    Uncle Bob devotees that I have worked with, have also written some of the most confusing, inscrutable code I have ever seen. Dependency Inversion I think is a poor idea though. It is fine if you must have many different versions. But I often thing one solid concrete implementation is better. where this really goes wrong is when people are so into Dependency Inversion that there is an IClass for every Class, doubling the amount of files, and <5% of these actually have more than one implementation. IMO I think going by the original idea of Object Orientation from Alan Kay is the real winner: Its all about message passing.
tdeck 3y ago
This is all fun and games until that person leaves the team or goes on vacation and some other project's tight deadline unexpectedly depends on understanding and fixing their poorly written code. People really discount the value of maintainable and understandable code until they've been in this position multiple times. Some people never learn it because they "fix" or modify things without understanding them, cause problems, and never reflect on how that happened.

digitalsushi 3y ago

The wink emoji is leaving me with the sensation I am out in the dark on something everyone else knows.

morbicer 3y ago
I am not sure what the wink is, I think SOLID is mostly solid but my advice is be wary of anyone who is a zealot follower of Uncle Bob :)
- ecshafer 3y ago
  Uncle Bob devotees that I have worked with, have also written some of the most confusing, inscrutable code I have ever seen. Dependency Inversion I think is a poor idea though. It is fine if you must have many different versions. But I often thing one solid concrete implementation is better. where this really goes wrong is when people are so into Dependency Inversion that there is an IClass for every Class, doubling the amount of files, and <5% of these actually have more than one implementation. IMO I think going by the original idea of Object Orientation from Alan Kay is the real winner: Its all about message passing.

tdeck 3y ago

This is all fun and games until that person leaves the team or goes on vacation and some other project's tight deadline unexpectedly depends on understanding and fixing their poorly written code. People really discount the value of maintainable and understandable code until they've been in this position multiple times. Some people never learn it because they "fix" or modify things without understanding them, cause problems, and never reflect on how that happened.